Repository navigation
Conversation
…nly when requests-specific env vars are absent
Pull request dashboard statusClosed · refreshed 2026-09-30 16:20 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
CA-bundle environment variables are incorrectly matched case-insensitively on POSIX.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes #5710 by selecting the requests transport when proxy or CA-bundle environment configuration requires it.
Changes:
- Adds environment-aware default transport selection.
- Applies selection to protobuf and JSON OTLP exporters.
- Adds tests, documentation, and changelog coverage.
| File | Description |
|---|---|
.changelog/5711.fixed |
Records the transport-selection fix. |
exporter/opentelemetry-exporter-http-transport/README.rst |
Documents proxy and CA-bundle behavior. |
exporter/opentelemetry-exporter-http-transport/src/opentelemetry/exporter/http/transport/__init__.py |
Implements environment-aware selection. |
exporter/opentelemetry-exporter-http-transport/tests/test_load_transport.py |
Tests selection and fallback behavior. |
exporter/opentelemetry-exporter-otlp-json-http/src/opentelemetry/exporter/otlp/json/http/_internal.py |
Uses dynamic default selection. |
exporter/opentelemetry-exporter-otlp-json-http/tests/test_internal.py |
Tests JSON exporter integration. |
exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py |
Uses dynamic selection without an explicit session. |
exporter/opentelemetry-exporter-otlp-proto-http/tests/test_common.py |
Tests protobuf exporter integration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Default to the urllib3 transport for HTTP exporters only when requests-specific environment variables are absent.
Fixes #5710
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tox
Does This PR Require a Contrib Repo Change?
Checklist: